[O2B-1460] Filtering on Runs per LHC Period overview page#1957
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1957 +/- ##
==========================================
- Coverage 45.81% 45.75% -0.06%
==========================================
Files 1019 1019
Lines 16863 16885 +22
Branches 3041 3038 -3
==========================================
+ Hits 7725 7726 +1
- Misses 9138 9159 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
To be merged after #1955 |
xsalonx
changed the title
graduta
requested changes
Aug 12, 2025
graduta
left a comment
graduta
left a comment
Member
There was a problem hiding this comment.
Given that the runs request already contains both the lhcPeriodId and lhcPeriodName and on top of that the table bug in which the request for runs and now for lhcPeriodStatistics are duplicated, is it worth doing a statistics request here on load?
I cannot see any other data being used from this request that would be displayed on the page
graduta
previously approved these changes
Aug 19, 2025
graduta
previously approved these changes
Aug 19, 2025
graduta
previously approved these changes
Aug 19, 2025
graduta
approved these changes
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a JIRA ticket
Notable changes for users:
Notable changes for developers:
Changes made to the database: